This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
#300 #302 #307 #308
I think this change will be enough to make it work on both Windows and Linux. I have tested in cmd.exe on windows, and on Ubuntu Konsole and VSCode integrated terminal. I cannot test on MacOS though because I don't own a Mac.
Logic behind this change:
In
cursor_windows.go
,PreviousLine()
callsDown()
andHorizontalAbsolute()
, so I just did the same for linux but withoutHorizontalAbsolute()
because it is apparently not needed (Test it on MacOS and tell me if it works. If it doesn't, then I think adding a call toHorizontalAbsolute()
would do the trick). This allows us to keepPreviousLine()
andNextLine()
and don't have a conflict in naming between the windows and other versions.