Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I feel like the intention here is to use replaceAll rather than replace #117

Closed
m1c43L opened this issue Aug 26, 2022 · 2 comments
Closed
Assignees
Labels

Comments

@m1c43L
Copy link

m1c43L commented Aug 26, 2022

alternateKeys[i] = alternateKeys[i].trim().replace('"', "'");

This is cause a buggy behavior when we are doing something like key=${JSON.stringify(value)}. It would only replace one of the double quote to single quote causing the line below it to throw.

@AleksandrRogov AleksandrRogov self-assigned this Aug 26, 2022
@AleksandrRogov
Copy link
Owner

@m1c43L true.

@AleksandrRogov
Copy link
Owner

going to replace it with a regular expression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants