Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Replace applymap with map for pd.DataFrame #180

Merged
merged 2 commits into from
Dec 11, 2023
Merged

fix: Replace applymap with map for pd.DataFrame #180

merged 2 commits into from
Dec 11, 2023

Conversation

esloch
Copy link
Collaborator

@esloch esloch commented Dec 7, 2023 •
edited
Loading

@esloch esloch requested review from fccoelho and luabida December 7, 2023 13:45
luabida
luabida reviewed Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@luabida luabida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some commented code in the PR. Is there any reason to keep them in the repo?

pysus/data/__init__.py Outdated Show resolved Hide resolved
pysus/online_data/IBGE.py Outdated
@@ -97,6 +97,12 @@ def get_sidra_table(
query += f'/h/{headers}'

url = base_url + query

#data = requests.get(url)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason to keep this dead code here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was testing these changes for a previous issue, I just uploaded it, I will remove it.

@esloch
Copy link
Collaborator Author

esloch commented Dec 8, 2023

I see some commented code in the PR. Is there any reason to keep them in the repo?

The commented codes are here because this PR has not yet been finalized, I still have to verify that we have tests for these functions, for this reason they still remain.

@esloch esloch requested a review from luabida December 8, 2023 09:15
@esloch esloch marked this pull request as ready for review December 11, 2023 11:58
@esloch esloch merged commit 357b7ca into main Dec 11, 2023
6 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fccoelho fccoelho fccoelho approved these changes

@luabida luabida Awaiting requested review from luabida

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]replace applymap by map
3 participants
@esloch @fccoelho @luabida