Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaky crash issue: TypeError: Range.setEnd: Argument 1 does not implement interface Node. #1245

Closed
scscgit opened this issue Aug 23, 2021 · 1 comment

Comments

@scscgit
Copy link

scscgit commented Aug 23, 2021

I observed issue of Trumbowyg crashing the page despite latest version https://github.com/Alex-D/Trumbowyg/releases/tag/v2.25.1, which had supposedly fixed an issue #1233 (fixed in 5ad49f3) that seems to be related based on the error message (TypeError: Range.setEnd: Argument 1 does not implement interface Node.). As the fix replaced t.range.startContainer.parentNode by t.range, I suspect that a similar check needs to be performed at

range.setEnd(savedRange.startContainer, savedRange.startOffset);

Note that I'm unable to reproduce this intentionally, and I don't have any debugging setup in place to discover the conditions or root cause. This doesn't usually occur (but it's fatal when it does, causing a motivation to wrap this component in some Vue error boundary - too bad https://github.com/ankurk91/vue-trumbowyg is archived so it can't be done there). I currently don't have any more information except the following screenshot(s):

image

It has occurred again, so at least I confirmed some variables in debugger:

image

Description

  • Microsoft Windows 10 Enterprise
  • Firefox 91.0.1 (64-bit)
@Alex-D
Copy link
Owner

Alex-D commented Nov 14, 2022

Nobody else has reported this bug, but maybe was fixed since, I do not know :/

@Alex-D Alex-D closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants