Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amd64 deb and zip are switched for release 121.0.1. #91

Closed
xiota opened this issue Jan 5, 2024 · 6 comments
Closed

amd64 deb and zip are switched for release 121.0.1. #91

xiota opened this issue Jan 5, 2024 · 6 comments

Comments

@xiota
Copy link

xiota commented Jan 5, 2024

The amd64 deb and zip are switched for release 121.0.1. The sse versions are okay.

$ mimetype -M *121.0.1*
mercury-browser_121.0.1_SSE3.deb:  application/vnd.debian.binary-package
mercury-browser_121.0.1_amd64.deb: application/zip
mercury_121.0.1_linux_SSE3.zip:    application/zip
mercury_121.0.1_linux_x64.zip:     application/vnd.debian.binary-package

$ sha256sum *121.0.1*
f6d848decd5ae459c48a637578542b54de669ee0e1a699d53e98ef2903a4c38f  mercury-browser_121.0.1_SSE3.deb
c6fc654a70cc534e75902a472ea0a7f6346bcae31cac7f259d064d2b2293ee91  mercury-browser_121.0.1_amd64.deb
a792753a98c893a0df80bb14c113e3b27b70b25ed995f9486ba841c06430d413  mercury_121.0.1_linux_SSE3.zip
11e254891aea054ab6587553bc54220f97f31cb5036b821537ee044dea8c3913  mercury_121.0.1_linux_x64.zip
@Alex313031
Copy link
Owner

@xiota UGHHH. THANK YOU.

@Alex313031
Copy link
Owner

Alex313031 commented Jan 6, 2024

@xiota UPDATE: Corrected.

Also, you need to update the thorium-sse3-bin aur package you maintain.

x86-64-v2 requires SSE4.1 and SSE4.2 support > https://en.wikipedia.org/wiki/X86-64#Microarchitecture_levels

Therefore, this package will not install on many systems that could otherwise run it.

Instead, you should have it check explicitly for SSE3 support. An idea for how to do that can be found in my check_simd.sh script in the repo > https://github.com/Alex313031/thorium/blob/main/check_simd.sh

@xiota
Copy link
Author

xiota commented Jan 7, 2024

The scripts print advisory notices only. They do not prevent the programs from continuing to run. I would rather tell the user it won't work, but have it work anyway, because in this case, most users will ignore or never even see the message. But if I tell the user it will work and it doesn't, they will come back to complain that it doesn't work.

So before updating the scripts, I would appreciate if you would point me to the specific config files used for each build. In the Thorium-SSE3 repo, I see files named sandybridge and tigerlake, which both support SSE4.x.

I'm also curious about why you chose some intermediate state between v1 and v2 instead of full v2.

@Alex313031
Copy link
Owner

Alex313031 commented Jan 7, 2024

@xiota All those repos no longer host any source code. I need to delete those files. All source code for all platforms and architectures is now in the main repo > https://github.com/Alex313031/thorium

As for why, because SSE3 is Chromium's baseline, and there are quite alot of CPUs that support SSE3 but not SSE4.2. For example 1st gen opteron and athlon, athlon XP, pentium 4 prescott, pentium D, pentium M, and core 2 duo/core 2 quad.

IMO x86-64-v2 should have been set at SSE4.1, not SSE4.2, since SSE4.2 was only introduced with 1st gen core, and even then, the lower end pentiums and celerons lacked it. In fact, this is the reason ChromiumOS (open source counterpart to ChromeOS) recently moved to SSE4.1. The bug tracker recommended x86-64-v2, but then they realized there are still some supported chromebooks that only have sse4.1.

@xiota
Copy link
Author

xiota commented Jan 7, 2024

I'll update the scripts. Does this also apply to mercury-browser-sse3-bin?

If the supported instruction sets change in a future build, please @ me.

@xiota
Copy link
Author

xiota commented Jan 7, 2024

Closing because confirmed files are fixed now:

$ mimetype -M *121*
mercury-browser_121.0.1_SSE3.deb:  application/vnd.debian.binary-package
mercury-browser_121.0.1_amd64.deb: application/vnd.debian.binary-package
mercury_121.0.1_linux_SSE3.zip:    application/zip
mercury_121.0.1_linux_x64.zip:     application/zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants