-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
amd64 deb and zip are switched for release 121.0.1. #91
Comments
@xiota UGHHH. THANK YOU. |
@xiota UPDATE: Corrected. Also, you need to update the thorium-sse3-bin aur package you maintain. x86-64-v2 requires SSE4.1 and SSE4.2 support > https://en.wikipedia.org/wiki/X86-64#Microarchitecture_levels Therefore, this package will not install on many systems that could otherwise run it. Instead, you should have it check explicitly for SSE3 support. An idea for how to do that can be found in my check_simd.sh script in the repo > https://github.com/Alex313031/thorium/blob/main/check_simd.sh |
The scripts print advisory notices only. They do not prevent the programs from continuing to run. I would rather tell the user it won't work, but have it work anyway, because in this case, most users will ignore or never even see the message. But if I tell the user it will work and it doesn't, they will come back to complain that it doesn't work. So before updating the scripts, I would appreciate if you would point me to the specific config files used for each build. In the Thorium-SSE3 repo, I see files named sandybridge and tigerlake, which both support SSE4.x. I'm also curious about why you chose some intermediate state between v1 and v2 instead of full v2. |
@xiota All those repos no longer host any source code. I need to delete those files. All source code for all platforms and architectures is now in the main repo > https://github.com/Alex313031/thorium As for why, because SSE3 is Chromium's baseline, and there are quite alot of CPUs that support SSE3 but not SSE4.2. For example 1st gen opteron and athlon, athlon XP, pentium 4 prescott, pentium D, pentium M, and core 2 duo/core 2 quad. IMO x86-64-v2 should have been set at SSE4.1, not SSE4.2, since SSE4.2 was only introduced with 1st gen core, and even then, the lower end pentiums and celerons lacked it. In fact, this is the reason ChromiumOS (open source counterpart to ChromeOS) recently moved to SSE4.1. The bug tracker recommended x86-64-v2, but then they realized there are still some supported chromebooks that only have sse4.1. |
I'll update the scripts. Does this also apply to If the supported instruction sets change in a future build, please @ me. |
Closing because confirmed files are fixed now:
|
The amd64 deb and zip are switched for release 121.0.1. The sse versions are okay.
The text was updated successfully, but these errors were encountered: