Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export also as ESM module #9

Closed
mojoaxel opened this issue Sep 23, 2020 · 6 comments · Fixed by #10
Closed

export also as ESM module #9

mojoaxel opened this issue Sep 23, 2020 · 6 comments · Fixed by #10
Labels
hacktoberfest-accepted hacktoberfest.digitalocean.com

Comments

@mojoaxel
Copy link
Collaborator

We get the following waning in an Angular project using keychartm (for vis-timeline):

WARNING in node_modules/vis-timeline/esnext/esm/vis-timeline-graph2d.js depends on 'keycharm'.
CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

It would be helpfull to also export a ESM module.
I'll try to look into this issue within the next weeks, but if somebody wants to help, please feel free to do so ;-)

@mojoaxel
Copy link
Collaborator Author

@AlexDM0 Maybe you can label this issue with Hacktoberfest!?
(see https://hacktoberfest.digitalocean.com/#maintainers)

@AlexDM0 AlexDM0 added the hacktoberfest-accepted hacktoberfest.digitalocean.com label Sep 23, 2020
@AlexDM0
Copy link
Owner

AlexDM0 commented Sep 23, 2020

@mojoaxel Sure, it's labeled. Let me know what you find!

@mojoaxel
Copy link
Collaborator Author

mojoaxel commented Oct 9, 2020

@AlexDM0 Sorry to bother you again but to be part of hacktoberfest the project needs a "topic" hacktoberfest to the project. ;-)

Maintainers of the repository can add the "hacktoberfest" topic to their repository if they wish to participate.
Alternatively, an individual PR can be opted-in with a maintainer adding the "hacktoberfest-accepted" label to the PR.

@AlexDM0
Copy link
Owner

AlexDM0 commented Oct 10, 2020

@mojoaxel I've added you as a contributor. I havent looked too much into hacktoberfest, so if you think this would be a fun candidate, I'll leave it up to you to add it :)

@mojoaxel
Copy link
Collaborator Author

I've added you as a contributor.

Thanks, but with the current rights I cannot add topics or labels 😉 but that's ok...

@AlexDM0
Copy link
Owner

AlexDM0 commented Oct 11, 2020

I see, I added the topic now. I didn't know those existed to be honest :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted hacktoberfest.digitalocean.com
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants