Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With a certain mod set CLS just *stops* loading #57

Open
AlexIIL opened this issue Oct 12, 2019 · 4 comments
Open

With a certain mod set CLS just *stops* loading #57

AlexIIL opened this issue Oct 12, 2019 · 4 comments
Labels

Comments

@AlexIIL
Copy link
Owner

AlexIIL commented Oct 12, 2019

Reported by CritFlaw in the buildcraft discord, with this log: https://gist.github.com/AlexIIL/de12ef9171a44d12e0764d272243b715

Essentially it just stops loading after it gets to "Completed: Ender Tweaker" (95%) and then just... stops.
image

@AlexIIL AlexIIL added the bug label Oct 12, 2019
@Liiw
Copy link

Liiw commented Nov 3, 2019

I noticed this behaviour with Optifine. Also noticed that the latest.log just ended and didn't show any reasons immediately before the stop. After removing Optifine, it worked again. Although later I saw that after waiting even longer, it managed to load with Optifine installed as well.

@RainbowTabitha
Copy link

Isnt an issue anymore. Just does take awhile to load

@AlexIIL
Copy link
Owner Author

AlexIIL commented Feb 23, 2020

I did some investigation a while ago and never wrote down the results - sorry.

It turns out this is caused by mods checking to see if the "shift" key is down while creating their tooltips (likely for JEI or something else), which gets blocked by the CLS thread for most of the time (as it's rendering). One solution to this would be to hack into the method to check to see if the shift key is down, and just assume not if CLS is currently rendering.

@smor777
Copy link

smor777 commented Dec 17, 2020

I noticed the same bug making a mod pack... I at first thought it was due to the fact that EnderIO has a warning about some missing Class but then I realized it always did that. So I tried the Optifine fix that @Liiw suggested and it worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants