-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDM: 250/256 steps #2
Comments
I've attempted to reproduce 256 steps for EDM with For the other numbers of steps, I have observed results matching those reported in the paper. Are there any other hyperparameters that need to be changed for evaluating with 256 steps? EDIT: Adding |
UPDATE: using |
Thank you for pointing out the typo! I You are right that I meant 256 steps for EDM SDE sampling. In terms of results SDE results replication, I am not sure if it is related to any other issues. It is convenient for you to check if the guided sampling result for EDM in fewer steps of ODE sampling first? Just to make sure the setting is right. Thank you for your response! Jiajun |
Hi,
thanks for the great paper and code. I found a potential typo and confusion on a result for EDM with 250/256 samples.
My confusion comes from 250 vs. 256 samples: In C.3 and 5.2, you state 250 samples. But then in C.4 and Table C.1, you say it's 256 samples. Also, the EDM source only provides guidance on 256 samples. Probably a typo and you meant actually always write 256 samples?
Also, rather than including 250/256 samples for EDM, you make a new table in the appendix. Why not include it in the actual paper? I mean the result is quite strong.
Thanks and best regards,
Felix
The text was updated successfully, but these errors were encountered: