Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alacritty terminal theme support #78

Open
PezCoder opened this issue Jul 30, 2023 · 9 comments
Open

Alacritty terminal theme support #78

PezCoder opened this issue Jul 30, 2023 · 9 comments
Assignees
Labels
Enhancement New feature, request or suggestion

Comments

@PezCoder
Copy link

PezCoder commented Jul 30, 2023

First off, beautiful theme! I'm coming from using Gruvebox & wanting to change it for a while, this gives a great fresh vibe & similar soothing color pallets 🌈

I use Alacritty as my terminal & ended up porting the theme using 🤖 chatgpt by inputting iterm2 nordic theme

This is what it gave me & with minor tweaks to selection colors, it looks pretty decent.

colors:
  # Default colors
  primary:
    background: '#242626'
    foreground: '#BBBDAF'

  # Normal colors
  normal:
    black: '#191C1D'
    red: '#BD6062'
    green: '#A3D6A9'
    yellow: '#F0DFAF'
    blue: '#8FB4D8'
    magenta: '#C7A9D9'
    cyan: '#B6D7A8'
    white: '#BDC5BD'

  # Bright colors
  bright:
    black: '#727C7C'
    red: '#D18FAF'
    green: '#B7CEB0'
    yellow: '#BCBCBC'
    blue: '#E0CF9F'
    magenta: '#C7A9D9'
    cyan: '#BBDA97'
    white: '#BDC5BD'


  # Selection color
  selection:
    text: '#000000'
    background: '#F0DFAF'

I'll wait for an "official" port to arrive, but meanwhile, others can use this as an alternative.

The official port whenever comes, can also be optionally added to: https://github.com/alacritty/alacritty-theme

@PezCoder
Copy link
Author

Here are some screenshots:

Screenshot 2023-07-30 at 12 45 10 PM Screenshot 2023-07-30 at 12 44 56 PM

@AlexvZyl AlexvZyl self-assigned this Jul 30, 2023
@AlexvZyl AlexvZyl added the Enhancement New feature, request or suggestion label Jul 30, 2023
@AlexvZyl
Copy link
Owner

I am actually really glad you compared this to gruvbox, as that is exactly what I wanted to replicate. Just not as brown. Glad you like it!

If you want you can submit a PR?

@AlexvZyl
Copy link
Owner

Just add some screenshots with the nordic background please.

@PezCoder
Copy link
Author

PezCoder commented Aug 3, 2023

@AlexvZyl Turned out my true colours weren't setup properly, hence you see a brownish background for my screenshots. I fixed that now.

& I checked color in VIM:

:hi Normal
" Normal         xxx guifg=#c0c8d8 guibg=#242933

& currently using this bg: #242933 in alacrity which matches vim's now.
Also not sure how chatgpt smartly converted the RGB values.

Let me take this up this weekend, I'll attach some screenshots in the PR.

@PezCoder
Copy link
Author

PezCoder commented Sep 4, 2023

@AlexvZyl A standard way to create themes in alacrity is within the alacritty-theme repository, I've created a pull request there:
alacritty/alacritty-theme#44

🔗 In case you'd like me to link this somewhere within this repository let me know, I'm unsure where can I do that.

🙏🏼 Would you please give it a review whenever you find the time & in case any color correction is needed?

✅ I've been using this for a while now & haven't really noticed any issues in my terminal & neovim since then.

@AlexvZyl
Copy link
Owner

Apologies for ghosting you... Things have been a bit busy this side.

Thanks for making the PR. Even though it is closed, I will still take a look and make changes if necessary! :)

After that I will close the issue.

@AlexvZyl
Copy link
Owner

It seems like you did not use the colors defined here?

@PezCoder
Copy link
Author

I primarily referred to the iterm2 variant mentioned in the docs, input it in chatgpt & spit out the alacrity theme pretty much:
https://github.com/AlexvZyl/nordic.nvim/blob/main/platforms/iTerm2/nordic.itermcolors

Let me know if you see something off & would like some changes

@AlexvZyl
Copy link
Owner

AlexvZyl commented Jan 3, 2024

We have to correct the colors to match those defined in this file. Would you be keen? If not, I will do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature, request or suggestion
Projects
None yet
Development

No branches or pull requests

2 participants