Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature required] pouch should support cpu-period and cpu-quota #1031

Closed
Letty5411 opened this issue Apr 2, 2018 · 3 comments · Fixed by #1067
Closed

[feature required] pouch should support cpu-period and cpu-quota #1031

Letty5411 opened this issue Apr 2, 2018 · 3 comments · Fixed by #1067
Assignees

Comments

@Letty5411
Copy link
Contributor

Ⅰ. Issue Description

pouch create/run should also support the following args:

--cpu-period=0                  Limit CPU CFS (Completely Fair Scheduler) period
  --cpu-quota=0                   Limit CPU CFS (Completely Fair Scheduler) quota

Ⅱ. Describe what happened

Ⅲ. Describe what you expected to happen

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?

Ⅵ. Environment:

  • pouch version (use pouch version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@allencloud
Copy link
Collaborator

allencloud commented Apr 2, 2018

Could you help to handle this issue? @YaoZengzeng
In addition, I am wondering if we need to refactor the spec related go files in /pouch/daemon/mgr/spec_*.go?

Since they are some kind of casual. In the past, when we adding a field in spec, we simply add a spec_*.go file.

@Ace-Tang
Copy link
Contributor

Ace-Tang commented Apr 3, 2018

I think spec related implement is not so good, lots of files /pouch/daemon/mgr/spec_*.go make this
complex.
@Letty5411 , you can just add this two spec field.

@allencloud
Copy link
Collaborator

I think spec related implement is not so good, lots of files /pouch/daemon/mgr/spec_*.go make this
complex.

Actually I cannot quite follow you. @Ace-Tang
Could you explain more on the complexity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants