Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] move related packages out of pkg #1051

Closed
allencloud opened this issue Apr 3, 2018 · 1 comment · Fixed by #1147
Closed

[refactor] move related packages out of pkg #1051

allencloud opened this issue Apr 3, 2018 · 1 comment · Fixed by #1147
Assignees

Comments

@allencloud
Copy link
Collaborator

allencloud commented Apr 3, 2018

Ⅰ. Issue Description

When I am learning the structure of package pkg, I find that there are at least three packages which should be moved out of it:

  • client
  • quota
  • runconfig

Here is my reason:
we usually keep totally general packages in package pkg, while three packages above are something specific, client is for control server or something like that, quota for filesystem quota for container, and runconfig is for pouch container's some kind of config parameter.

I wish we could add a folder which is named storage, then some structure may be like:

storage:
     \___volume
      \__quota
       \_ controlserver
                 \_client

Actually I am afraid the package name of client is not my dishes. Like the code makes me feel confused:

return client.JoinURL(c.BaseURL, types.APIVersion, client.StoragePath)

Here, I think client is a struct instance, however it is a package. So hard to understand and quite awkward.

@allencloud
Copy link
Collaborator Author

discussed with @rudyfly and @HusterWan offline. Also sponsor the point of view above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants