Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flaky test] PouchRestartSuite.TestPouchRestart fails unexpectedly #1323

Closed
allencloud opened this issue May 15, 2018 · 1 comment · Fixed by #1341
Closed

[flaky test] PouchRestartSuite.TestPouchRestart fails unexpectedly #1323

allencloud opened this issue May 15, 2018 · 1 comment · Fixed by #1341
Assignees

Comments

@allencloud
Copy link
Collaborator

Ⅰ. Issue Description

When I searching Ci failure of pr #1307, I found some flaky test there. And I try to reproduce them in the CI system and on my local machine. Unfortunately, I failed to make it.

Here is the flaky test error message. While although it is flaky, I have no idea about what happened in the test case. I am wondering if we could find a way to throw out some detailed error message? @Letty5411

----------------------------------------------------------------------
FAIL: /go/src/github.com/alibaba/pouch/test/cli_restart_test.go:34: PouchRestartSuite.TestPouchRestart
/go/src/github.com/alibaba/pouch/test/cli_restart_test.go:40:
    c.Assert(res.Error, check.IsNil)
... value *exec.ExitError = &exec.ExitError{ProcessState:(*os.ProcessState)(0xc420cb56c0), Stderr:[]uint8(nil)} ("exit status 1")

Ⅱ. Describe what happened

Ⅲ. Describe what you expected to happen

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?

Ⅵ. Environment:

  • pouch version (use pouch version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@Letty5411
Copy link
Contributor

The following c.Assert could be changed to res.Assert

        res := command.PouchRun("restart", "-t", "1", name)
	c.Assert(res.Error, check.IsNil)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants