New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[help wanted] replace DelContainerForceOk with DelContainerForceMultyTime #1376

Closed

Letty5411 opened this issue May 22, 2018 · 0 comments · Fixed by #1462

Labels

Contributor

Letty5411 commented May 22, 2018 •

edited

Loading

Ⅰ. Issue Description

Due to issue #815 tests fail randomly.
Now in cli_xxx_test.go, they all use function DelContainerForceMultyTime instead of DelContainerForceOk. The former function will try several times to delete a container and ignore the return value.

Ⅱ. Describe what happened

Ⅲ. Describe what you expected to happen

Replace DelContainerForceOk in api_xxx_test.go with the following statement:

defer DelContainerForceMultyTime(c, cname)

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?

Ⅵ. Environment:

pouch version (use pouch version):
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

The text was updated successfully, but these errors were encountered:

Letty5411 added the help wanted label

zhuangqh mentioned this issue

fix: replace DelContainerForceOk with DelContainerForceMultyTime #1462

Merged

allencloud closed this as completed in #1462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment