Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature-request] support publishAll flag in container's command line #2517

Closed
allencloud opened this issue Nov 30, 2018 · 0 comments · Fixed by #2545
Closed

[feature-request] support publishAll flag in container's command line #2517

allencloud opened this issue Nov 30, 2018 · 0 comments · Fixed by #2545
Assignees
Labels
areas/cli kind/feature kind/feature-request This is a feature request from community for PouchContainer

Comments

@allencloud
Copy link
Collaborator

Ⅰ. Issue Description

In the #2500 (comment), we discussed about the flag publishAll or publicAll.

In https://github.com/alibaba/pouch/blob/master/cli/container.go#L68, we have field publicAll bool.

But I am afraid that we have not used this field in anywhere.

However, in Moby/Docker, we have https://github.com/docker/cli/blob/2634562119dd5b4e64d529d1aa5e16f760382d5f/cli/command/container/opts.go#L69:

publishAll         bool

And the flag :

flags.BoolVarP(&copts.publishAll, "publish-all", "P", false, "Publish all exposed ports to random ports")

Ⅱ. Describe what happened

no support publish-all flag

Ⅲ. Describe what you expected to happen

support publish-all flag

@pouchrobot pouchrobot added areas/cli kind/feature kind/feature-request This is a feature request from community for PouchContainer labels Nov 30, 2018
@ZYecho ZYecho self-assigned this Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/cli kind/feature kind/feature-request This is a feature request from community for PouchContainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants