Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[help wanted] Sirupsen caused installation to fail #949

Closed
faycheng opened this issue Mar 23, 2018 · 3 comments · Fixed by #953
Closed

[help wanted] Sirupsen caused installation to fail #949

faycheng opened this issue Mar 23, 2018 · 3 comments · Fixed by #953
Assignees
Labels
kind/bug This is bug report for project

Comments

@faycheng
Copy link
Contributor

Ⅰ. Issue Description

➜  pouch git:(master) ✗ make install
GOOS=linux go build -o pouchd
daemon/mgr/network.go:17:2: case-insensitive import collision: "github.com/alibaba/pouch/vendor/github.com/Sirupsen/logrus" and "github.com/alibaba/pouch/vendor/github.com/sirupsen/logrus"
make: *** [Makefile:23: server] Error 1

logrus organization's name was changed to lower-case.If we use the upper-case import :Sirupsen/logrus,conflicts would happen due to case sensitivity.

Ⅱ. Describe what happened

Ⅲ. Describe what you expected to happen

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?

https://github.com/sirupsen/logrus#case-sensitivity
sirupsen/logrus#384

Ⅵ. Environment:

  • pouch version (use pouch version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@allencloud
Copy link
Collaborator

Yes, we have suffered this for quite a long time. We are also finding ways to handle this. Do you have any ideas to fix this?

In addition, are you build Pouch in a MacOS? If that, I think there is something we need to config, Since by default, MacOS does not recognize the uppercase or lowercase of directory.

also cc @rudyfly Who is more familiar with this part.

@allencloud allencloud added the kind/bug This is bug report for project label Mar 23, 2018
@faycheng
Copy link
Contributor Author

yes,i will make a pull request to correct the import path.
In addition, i did make install in a MacOS.What configurations are required to set up in MacOS?Is there any documents to explain this?
Thanks.

@allencloud
Copy link
Collaborator

This issue is similar with #750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants