Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test]cli_rich_container_test.go:151 failes to validate stdout #960

Closed
faycheng opened this issue Mar 24, 2018 · 3 comments
Closed

[test]cli_rich_container_test.go:151 failes to validate stdout #960

faycheng opened this issue Mar 24, 2018 · 3 comments
Assignees

Comments

@faycheng
Copy link
Contributor

faycheng commented Mar 24, 2018

Ⅰ. Issue Description

sometimes cli_rich_container_test.go:151 fails to validate stdout, here(tavis log) can give us more details.

err=
Command:  /usr/local/bin/pouch exec TestRichContainerInitdWorks ps -ef | grep /sbin/init | awk '{print $1}'
ExitCode: 0
Error:    <nil>
Stdout:   
Stderr:   
Failures:
Expected stdout to contain "1"
----------------------------------------------------------------------
FAIL: /go/src/github.com/alibaba/pouch/test/cli_rich_container_test.go:151: PouchRichContainerSuite.TestRichContainerInitdWorks
/go/src/github.com/alibaba/pouch/test/cli_rich_container_test.go:182:
    c.Assert(checkPidofProcessIsOne(funcname, "/sbin/init"), check.Equals, true)
... obtained bool = false
... expected bool = true

Ⅱ. Describe what happened

Ⅲ. Describe what you expected to happen

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?

Ⅵ. Environment:

  • pouch version (use pouch version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@Letty5411
Copy link
Contributor

I think this is a flaky test, we may need to enhance or skip it.

@Ace-Tang
Copy link
Contributor

Command:  /usr/local/bin/pouch exec TestRichContainerInitdWorks ps -ef | grep /sbin/init | awk '{print $1}'
ExitCode: 1
Error:    exit status 1
Stdout:   error: garbage option
Usage:
 ps [options]
 Try 'ps --help <simple|list|output|threads|misc|all>'
  or 'ps --help <s|l|o|t|m|a>'
 for additional help text.
For more details see ps(1).
Stderr:   
Failures:
ExitCode was 1 expected 0
Expected no error

it seems like a ps command error, I have no idea whether it has related with my modification, #1128

@allencloud
Copy link
Collaborator

Could you take a look on this, whether this is still an issue for PouchContainer? @Letty5411 @Ace-Tang
If not flaky any more, I think we can close this.

@rudyfly rudyfly closed this as completed Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants