Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tip: Using Aspect Ratio instead of usual Margin and Padding #141

Closed
farheen21 opened this issue Aug 16, 2021 · 6 comments
Closed

Add tip: Using Aspect Ratio instead of usual Margin and Padding #141

farheen21 opened this issue Aug 16, 2021 · 6 comments

Comments

@farheen21
Copy link

I think this repo must contain the aspect ratio hack...It can be use widely in hero section , responsive styling and grid based content....
Here is more info about the aspect ratio hack
please do let me know if its best fit for the repo and if yes I would like to send a PR for this

@AllThingsSmitty
Copy link
Owner

@farheen21 thanks for the suggestion. I hadn't consider aspect-ratio, but feel free to submit a PR and I'll review it.

@vinaybharadwaj007
Copy link

Pr

@robsonsobral
Copy link

aspect-ratio isn't a hack, but a standard CSS property. I can't see a reason for consider it a tip.

@tusharrajpoot
Copy link

@AllThingsSmitty can you assign it to me?

@mansi142003
Copy link

can you assign to me?

@princesingh04
Copy link

can you assign this to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants