-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Conjunction (&&) as Search Mode #1199
Comments
PR #1196 is implementing this. Please have a look. 😄 |
@CarstenWickner, thanks your proposal, I thinks it's a nice feature and I'll spend some time to review your PR. Thanks a lot :) BTW, A awesome compared table 👍 |
I'm glad you like the idea. There seems to be at least the beginning of a |
Actually, this project is my first repo for practicing Anyway, you can skip the testing, that is ok for this repo but not ok for software development 👍 |
Release at |
Currently, two very different search modes are supported:
searchText
contained as-is in any of their cells. (default)searchText
. (multiColumnSearch: true
)One could argue whether "multiple columns" are any differentiation between these two cases, but that's not my point here.
I merely want to point out that for some use cases the (default) option (1) is too strict and the alternative option (2) is not strict enough.
Therefore I propose introducing an additional
strictSearch
prop opening up the way for four different search modes, i.e. two more options.I'll demonstrate the difference with a single row as example:
Search modes and whether they would include the above row for the given
searchText
searchText
strict && !multiColumn
(existing option 1)!strict && !multiColumn
strict && multiColumn
!strict && multiColumn
(existing option 2)The text was updated successfully, but these errors were encountered: