Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded warning in ToolBar.js: #1213

Closed
genau7 opened this issue Apr 10, 2017 · 2 comments
Closed

Hardcoded warning in ToolBar.js: #1213

genau7 opened this issue Apr 10, 2017 · 2 comments

Comments

@genau7
Copy link

genau7 commented Apr 10, 2017

Hello, I am creating a web app which can be viewed in many languages. While working with InsertModal and validation, I noticed that a warning pops up with a hardcoded message in ToolBar.js:

displayCommonMessage = () => {
    this.refs.notifier.notice(
      'error',
      'Form validate errors, please checking!',
      'Pressed ESC can cancel');
  }

Would it be possible for one of the library contributors to make those 3 strings customizable? And if not, could you please fix the error in the second string? (Please checking => Please check).

@AllenFang
Copy link
Owner

you can custom it via editable.validator, for example

But it not a good idea to custom the notification, I'll find a better solution in near future

@AllenFang
Copy link
Owner

AllenFang commented Aug 6, 2017

Release on v4.0.0, use options.insertFailIndicator to change the error message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants