Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in selectRow className #488

Closed
itajaja opened this issue Jun 3, 2016 · 2 comments · Fixed by #490
Closed

error in selectRow className #488

itajaja opened this issue Jun 3, 2016 · 2 comments · Fixed by #490
Labels

Comments

@itajaja
Copy link
Contributor

itajaja commented Jun 3, 2016

I believe this is a bug. Say I have my table with trClassName="foo" and selectRow={{ className: "bar", ... }} props. As it's clear from this code, when the row is selected, the class parameter will be foobar, instead of foo bar which is what I would expect. A workaround is to do selectRow={{ className: "bar ", ... }} but it feels kind of hacky. I can work on a fix if you agree

@itajaja
Copy link
Contributor Author

itajaja commented Jun 3, 2016

I also suggest to use the classnames package to handle class chaining

@AllenFang AllenFang added the bug label Jun 4, 2016
@AllenFang
Copy link
Owner

@itajaja, yes, it's a bug. react-bootstrap-table has been used classnames but some place did not used, it's also a improvement for handling class. Anyway, PR is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants