Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination PropType Invalid #592

Closed
madeinfree opened this issue Jul 28, 2016 · 2 comments
Closed

Pagination PropType Invalid #592

madeinfree opened this issue Jul 28, 2016 · 2 comments
Labels
enhancement

Comments

@madeinfree
Copy link
Contributor

madeinfree commented Jul 28, 2016 •
edited
Loading

I found this weird issue with paginationShowsTotal, it happened when give this prop a function, but here validate expected type of 'boolean'.

2016-07-28 9 39 55
@AllenFang
Copy link
Owner

AllenFang commented Aug 1, 2016 •
edited
Loading

um, I think I forgot to use oneOfType when support paginationShowsTotal can be customize if a function given. I'll fix it quickly.

@AllenFang
Copy link
Owner

Fixed on v2.4.3. Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@madeinfree @AllenFang