Removing a column with filter set will filter all data

[snowzach]

I am dynamically adding and removing columns from the table. If I remove a column that has a filter set, it seems to filter all of the rows from what's left in the table until I re-enable the column and then change the filter value.

[snowzach]

Okay, if I call applyFilter('') on a column just before it is removed it doesn't cause a problem.

[AllenFang]

ok, feel free to discuss with me if you got some trouble, I'll spend some time to check this out. Thanks

[snowzach]

It still kind of feels like a bug to me. If a column is removed from the table, it's like the filter remains but there is no data to filter (because the column is gone) on so it somehow defaults to filtering all the data.

[AllenFang]

@snowzach, any simple example for me to reproduce this issue? thanks you 👍

[louisblin]

Hi @AllenFang ,

I ran into the same issue recently, here is a minimal example that reproduces the problem - https://jsfiddle.net/x631b92m/. It does feel like a bug, I could work on a PR if that's something you'd like to fix.

Thanks :)

[AllenFang]

@louisblin, thanks your example code, 👍 it's real a bug and any idea to fix it? i think I can fix it in near future, but if you want to contribute, will be welcome :)

[louisblin]

Hi @AllenFang ,

It took me ages to find some time to spend on that, but I eventually got something working. I guess we should move the implementation discussion to the PR now

[AllenFang]

Released on v4.0.5, thanks 👍