Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlight stop works when auto-complete query failed #559

Closed
Slach opened this issue May 15, 2024 · 1 comment · Fixed by #563
Closed

Syntax highlight stop works when auto-complete query failed #559

Slach opened this issue May 15, 2024 · 1 comment · Fixed by #563
Assignees
Labels
bug p1 Priority 1
Milestone

Comments

@Slach
Copy link
Collaborator

Slach commented May 15, 2024

I created gh-api datasource which has restriction to system.* tables
and returns Code: 497. DB::Exception: play: Not enough privileges for auto-complete queries

Thereafter, I tried to make the following actions sequence:

Main menu -> Alert rules -> Add new rule

choose Column timestamp type -> DateTime
select Database, Table and Timestamp column

image

press Go to query

and syntax highlight stop works
image

@Slach Slach added this to the 3.1.1 milestone May 15, 2024
@Slach Slach added bug p1 Priority 1 labels May 15, 2024
@Slach
Copy link
Collaborator Author

Slach commented May 15, 2024

@lunaticusgreen also looks like auto-complete query fetch is synchronous
i mean we wait when it complete before trying to show query editor

This was referenced May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug p1 Priority 1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants