Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move standard texts from app frontend to Altinn org repo #4791

Closed
14 tasks
Tracked by #4450
nkylstad opened this issue Sep 15, 2020 · 1 comment
Closed
14 tasks
Tracked by #4450

Move standard texts from app frontend to Altinn org repo #4791

nkylstad opened this issue Sep 15, 2020 · 1 comment
Labels
area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. area/text-editor Area: Related to creating, translating and editing texts. area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. kind/user-story Used for issues that describes functionality for our users. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Milestone

Comments

@nkylstad
Copy link
Member

Description

Ref. analysis in #4450.
We should create an org repo for Altinn, where we store any shared resources that are available for all apps. This includes the standard texts that are currently in app frontend.

Screenshots

Screenshots or links to Figma (make sure your sketch is public)

Considerations

  • Create an org repo for Altinn, that can contain shared resources
    • This will work as a kind of POC for fetching shared resources from other org repos in the future.
  • Text resources from app frontend should be added to this repo
    • Note that the format for the text resources needs to be updated, from nested json to pure key/value pairs. The nesting can be represented using .-notation, f.ex:
"general": {
  "open": "Open"
}

should be converted to

"general.open": "Open"
  • When a new app is created, fetch text resources from Altinn org repo, and put them into the app repo together with the app texts.
  • Add a button (or something like it) in Designer that allows app developer to trigger an update of the standard texts (fetch the latest version into the app repo).
    • This should also automatically add the files to existing apps that do not have these texts yet.
  • Make sure that the standard text resources are deployed to cosmosDB in the same way as app texts during deploy.

Acceptance criteria

Describe criteria here (i.e. What is allowed/not allowed (negative tesing), validations, error messages and warnings etc.)

  • An org repo for Altinn is set up, and contains the text resources that were previously in app frontend
  • It is possible for app developers to update standard texts in their app to the newest version from the Altinn org repo

Specification tasks

  • Development tasks are defined
  • Test design / decide test need
  • Design mechanism for fetching latest standard texts to app (button?)

Development tasks

  • Set up Altinn org repo
  • Add standard texts from app frontend (with key/value format) to org repo
  • Implement mechanism for fetching latest standard texts
  • Update deploy to include pushing standard texts to cosmosDB

Definition of done

Verify that this issue meets DoD (Only for project members) before closing.

  • Documentation is updated (if relevant)
    • Technical documentation (docs.altinn.studio)
    • User documentation (altinn.github.io/docs)
  • QA
  • Manual test is complete (if relevant)
  • Automated test is implemented (if relevant)
  • All tasks in this userstory are closed (i.e. remaining tasks are moved to other user stories or marked obsolete)
@nkylstad nkylstad added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. area/text-editor Area: Related to creating, translating and editing texts. area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. solution/studio/designer Issues related to the Altinn Studio Designer solution. kind/user-story Used for issues that describes functionality for our users. labels Sep 15, 2020
@nkylstad nkylstad added this to the 2020-September milestone Sep 16, 2020
@lvbachmann lvbachmann modified the milestones: 2020-September, 2020-Q4 Oct 1, 2020
@lvbachmann lvbachmann modified the milestones: 2020-Q4, 2021-Q1 Feb 9, 2021
@lvbachmann lvbachmann modified the milestones: 2021-Q1, 2021-Q4 Aug 9, 2021
@nkylstad nkylstad mentioned this issue Jun 9, 2022
18 tasks
@haakemon haakemon moved this to Todo in Team Studio (old) Aug 12, 2022
@nkylstad nkylstad moved this to Todo in Team Studio Oct 10, 2022
@nkylstad
Copy link
Member Author

Closing this, as we have decided to keep standard texts in app frontend for now.

Repository owner moved this from 📈 Todo to ✅ Done in Team Studio Oct 21, 2022
Repository owner moved this from Todo to Done in Team Studio (old) Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. area/text-editor Area: Related to creating, translating and editing texts. area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. kind/user-story Used for issues that describes functionality for our users. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Status: Done
Development

No branches or pull requests

2 participants