Skip to content

Removing support for non-layoutset apps #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #339 ...
olemartinorg opened this issue Sep 25, 2023 · 2 comments · Fixed by #1814
Closed
Tracked by #339 ...

Removing support for non-layoutset apps #1485

olemartinorg opened this issue Sep 25, 2023 · 2 comments · Fixed by #1814
Assignees
Labels
fe-v4 Issues to be solved before v4 goes gold kind/breaking-change Issue/pull request containing a breaking change quality/debt

Comments

@olemartinorg
Copy link
Contributor

Description

We should remove support for non-layoutset apps. This would require that Studio has a tool for converting existing apps to use layout-sets, and that our app-template also uses layout-sets.

Removing this gets rid of a known source of bugs, and makes it more obvious where one should put configuration for new functionality (such as the custom receipt, see #1468).

Additional Information

We also have to implement:

Bugs caused by not taking non-layoutset apps into consideration:

@olemartinorg olemartinorg added quality/debt kind/breaking-change Issue/pull request containing a breaking change labels Sep 25, 2023
@olemartinorg olemartinorg added the fe-v4 Issues to be solved before v4 goes gold label Sep 25, 2023
@olemartinorg
Copy link
Contributor Author

We should have support for converting apps in the upgrade tool as well. 🤩 And we have to double-check the tool that exists in Studio before we can consider this.

@RonnyB71
Copy link
Member

RonnyB71 commented Nov 3, 2023

cc: @nkylstad are you ready for this? We will create a migration for this in the conversion tool and update the template as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fe-v4 Issues to be solved before v4 goes gold kind/breaking-change Issue/pull request containing a breaking change quality/debt
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants