Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Paragraph component should throw errors if given invalid elements #1487

Closed
Tracked by #339
, #1660
...
olemartinorg opened this issue Sep 25, 2023 · 0 comments · Fixed by #1670
Closed
Tracked by #339
, #1660
...

The Paragraph component should throw errors if given invalid elements #1487

olemartinorg opened this issue Sep 25, 2023 · 0 comments · Fixed by #1670
Assignees
@lassopicasso
Labels
fe-v4 Issues to be solved before v4 goes gold kind/breaking-change Issue/pull request containing a breaking change kind/bug Something isn't working

Comments

@olemartinorg
Copy link
Contributor

olemartinorg commented Sep 25, 2023 •
edited
Loading

Description of the bug

The Paragraph component should perhaps only accept strings as children, or produce warnings/errors when given elements that are not possible to render in a paragraph. This is because there are several rules as to what type of elements are allowed inside a paragraph. Currently you can pass any content (such as headings), which would result in

heading

which is invalid HTML, and breaking WCAG rules.

Additional Information
@olemartinorg olemartinorg added kind/bug Something isn't working status/triage kind/breaking-change Issue/pull request containing a breaking change and removed status/triage labels Sep 25, 2023
@olemartinorg olemartinorg mentioned this issue Sep 25, 2023
Closed
@olemartinorg olemartinorg added the fe-v4 Issues to be solved before v4 goes gold label Sep 25, 2023
@olemartinorg olemartinorg mentioned this issue Oct 6, 2023
Open
@RonnyB71 RonnyB71 mentioned this issue Nov 22, 2023
Closed
@lassopicasso lassopicasso self-assigned this Nov 23, 2023
@lassopicasso lassopicasso moved this to 👷 In Progress in Team Apps Nov 23, 2023
@lassopicasso lassopicasso mentioned this issue Nov 29, 2023
Merged
19 tasks
@HanneLauritsen1967 HanneLauritsen1967 moved this from 👷 In Progress to 🔎 Review in Team Apps Nov 30, 2023
@HanneLauritsen1967 HanneLauritsen1967 moved this from 🔎 Review to 🧪 Test in Team Apps Dec 1, 2023
@olemartinorg olemartinorg moved this from 🧪 Test to ✅ Done in Team Apps Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lassopicasso lassopicasso

Labels
fe-v4 Issues to be solved before v4 goes gold kind/breaking-change Issue/pull request containing a breaking change kind/bug Something isn't working
Projects
Team Apps
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ParagraphComponent with fallback on <div> if block-level elements Altinn/app-frontend-react
2 participants
@olemartinorg @lassopicasso