Skip to content

Summary: Remove pageRef configuration option #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #339
, #1660
...
olemartinorg opened this issue Sep 25, 2023 · 0 comments · Fixed by #1578
Closed
Tracked by #339
, #1660
...

Summary: Remove pageRef configuration option #1488

olemartinorg opened this issue Sep 25, 2023 · 0 comments · Fixed by #1578
Assignees
@bjosttveit
Labels
fe-v4 Issues to be solved before v4 goes gold kind/breaking-change Issue/pull request containing a breaking change

Comments

@olemartinorg
Copy link
Contributor

After the node hierarchy was implemented, we don't really need to know the page name each component should be fetched from, as we can just find the closest one. Removing this configuration option would make it easier to configure a Summary.
@olemartinorg olemartinorg added the kind/breaking-change Issue/pull request containing a breaking change label Sep 25, 2023
@olemartinorg olemartinorg mentioned this issue Sep 25, 2023
Closed
@olemartinorg olemartinorg added the fe-v4 Issues to be solved before v4 goes gold label Sep 25, 2023
@bjosttveit bjosttveit mentioned this issue Oct 16, 2023
Merged
19 tasks
@bjosttveit bjosttveit moved this to 🔎 Review in Team Apps Oct 16, 2023
@bjosttveit bjosttveit self-assigned this Oct 17, 2023
@bjosttveit bjosttveit moved this from 🔎 Review to 🧪 Test in Team Apps Oct 17, 2023
@HanneLauritsen1967 HanneLauritsen1967 moved this from 🧪 Test to ✅ Done in Team Apps Oct 18, 2023
@RonnyB71 RonnyB71 mentioned this issue Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjosttveit bjosttveit

Labels
fe-v4 Issues to be solved before v4 goes gold kind/breaking-change Issue/pull request containing a breaking change
Projects
Team Apps
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove pageRef property from Summary component Altinn/app-frontend-react
2 participants
@olemartinorg @bjosttveit