Skip to content

Remove legacy filter option for repeating groups #1493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #339
, #1660
...
olemartinorg opened this issue Sep 25, 2023 · 0 comments · Fixed by #1631
Closed
Tracked by #339
, #1660
...

Remove legacy filter option for repeating groups #1493

olemartinorg opened this issue Sep 25, 2023 · 0 comments · Fixed by #1631
Assignees
@lassopicasso
Labels
fe-v4 Issues to be solved before v4 goes gold kind/breaking-change Issue/pull request containing a breaking change

Comments

@olemartinorg
Copy link
Contributor

olemartinorg commented Sep 25, 2023 •
edited
Loading

We should remove the legacy filter functionality for repeating groups, as it has been superseded by the hiddenRow property. The only thing we don't have support for in hiddenRow is the start/stop index functionality, so that part cannot be removed.

See the function getRepeatingGroupFilteredIndices specifically.
@olemartinorg olemartinorg added the kind/breaking-change Issue/pull request containing a breaking change label Sep 25, 2023
@olemartinorg olemartinorg mentioned this issue Sep 25, 2023
Closed
@olemartinorg olemartinorg added the fe-v4 Issues to be solved before v4 goes gold label Sep 25, 2023
@lassopicasso lassopicasso self-assigned this Oct 30, 2023
@lassopicasso lassopicasso moved this to 👷 In Progress in Team Apps Oct 30, 2023
@lassopicasso lassopicasso mentioned this issue Nov 6, 2023
Merged
19 tasks
@lassopicasso lassopicasso moved this from 👷 In Progress to 🔎 Review in Team Apps Nov 6, 2023
@lassopicasso lassopicasso moved this from 🔎 Review to 🧪 Test in Team Apps Nov 10, 2023
@lassopicasso lassopicasso moved this from 🧪 Test to ✅ Done in Team Apps Nov 10, 2023
@RonnyB71 RonnyB71 mentioned this issue Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lassopicasso lassopicasso

Labels
fe-v4 Issues to be solved before v4 goes gold kind/breaking-change Issue/pull request containing a breaking change
Projects
Team Apps
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove redudant filter functionality that hidden-expression covers Altinn/app-frontend-react
2 participants
@olemartinorg @lassopicasso