Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update group component UI to indicate what elements are within the group. #436

Closed
8 tasks
Tracked by #115
FTLems opened this issue Nov 9, 2021 · 4 comments · Fixed by #1200
Closed
8 tasks
Tracked by #115

Update group component UI to indicate what elements are within the group. #436

FTLems opened this issue Nov 9, 2021 · 4 comments · Fixed by #1200
Assignees
Labels
feature-complete Features needed for parity with Altinn 2 (target: June 2023) kind/user-story Used for issues that describes functionality for our users. org/krt ux Needs some love from a UX resource

Comments

@FTLems
Copy link
Contributor

FTLems commented Nov 9, 2021

Description

FT needs a better indication in the frontend on what elements belongs in the same group. Per today, this is only visible in repeating group.

Screenshots

Following screenshot is from Altinn 2.0:
image

Screenshot from Altinn 3.0:

image
(Note: Point 2.3 is not included in group 2.2, but is still aligned close to point 2.2.4, which makes it difficult to interpret that it is not in the same group.)

Considerations

Suggest that elements within a group have padding, or slightly different background color as in Altinn 2.0.

Ops requirements

Are there any requirements for monitoring? What is being built and what could go wrong?
Are there any requirements related to backup?

Acceptance criteria

Describe criteria here (i.e. What is allowed/not allowed (negative tesing), validations, error messages and warnings etc.)

Specification tasks

  • Development tasks are defined

Development tasks

Add tasks here

Test

Add test cases here as checkboxes that are being tested as part of the changes.

Definition of done

Verify that this issue meets DoD (Only for project members) before closing.

  • Documentation is updated (if relevant)
    • Technical documentation (docs.altinn.studio)
    • User documentation (altinn.github.io/docs)
  • QA
  • Manual test is complete (if relevant)
  • Automated test is implemented (if relevant)
  • All tasks in this userstory are closed (i.e. remaining tasks are moved to other user stories or marked obsolete)

Design solution

If a group of input fields consists of a header, body text and input fields, the header and body text should be aligned and the input fields should be indented with a vertical line on the left side starting from the input fields. Conversely, in the case of groups within a group, the header, body text and input fields should be aligned with a vertical line on the left side starting from the header.

Skjermbilde 2023-05-25 kl  13 38 15

For input field components with a header, that are not created as part of groups, the input field is not indented with a vertical line to the left.

Skjermbilde 2023-05-25 kl  09 42 16

https://www.figma.com/file/Pvti3aRcOwH0k5Z7DrLznk/Arbeidsomr%C3%A5de%3A-Altinn-Studio-APPS?type=design&node-id=4639%3A103560&t=ni8ThCJyqL5s97BF-1

@FTLems FTLems added the kind/user-story Used for issues that describes functionality for our users. label Nov 9, 2021
@FinnurO FinnurO transferred this issue from Altinn/altinn-studio Sep 5, 2022
@FinnurO FinnurO added the org/krt label Sep 5, 2022
@olemartinorg
Copy link
Contributor

olemartinorg commented Nov 1, 2022

@FinnurO FinnurO added the ux Needs some love from a UX resource label Dec 16, 2022
@FinnurO FinnurO moved this to Backlog in Design Altinn 3 Dec 16, 2022
@FinnurO FinnurO added the feature-complete Features needed for parity with Altinn 2 (target: June 2023) label Mar 3, 2023
@RonnyB71
Copy link
Member

RonnyB71 commented Mar 28, 2023

Options

  • Should 2.3 be created as a group with a single field the get the layout/ux consistent?
  • Can panel be used instead of a group?
  • Should group have a way of showing the elements within a group?

@RonnyB71 RonnyB71 moved this to 📈 Todo in Team Apps May 22, 2023
@Magnusrm Magnusrm moved this from 📈 Todo to 👷 In Progress in Team Apps May 22, 2023
@Magnusrm Magnusrm assigned Magnusrm and unassigned Magnusrm May 22, 2023
@Magnusrm Magnusrm moved this from 👷 In Progress to 📈 Todo in Team Apps May 23, 2023
@FinnurO
Copy link

FinnurO commented May 23, 2023

La merke til denne fordi behovet kom opp i en annen app.

Linken @olemartinorg la inn er kanskje en duplikat av denne? https://docs.altinn.studio/app/development/ux/fields/grouping/panel/

Jeg tenker at panel burde passe til dette med kanskje et par justeringer;

  1. introdusere en 4de variant; "Gruppe" for å skille fra Info, Warning og Error. Den kan f.eks da styre:
    a) fargebakgrunn slik at den skiller seg ut fra andre panel. Må bestå kontrastkrav i forhold til Wcag
    b) vurdere om bredden på panelet kun omslutter komponentene og ikke hele bredden. Da ville den også bli oppfattet som en gruppering.

Mye av det som FT meldte inn er vel mulig med panel group, info og uten bruk av ikon? Hvis man i tillegg bruker innergrid/labelgrid så er man vel kanskje der i forholdet til eksempelet fra Altinn 2?

Kan være denne kan vente; har vi sjekket med FT ? Det er 18 mnd siden de opprettet saken.

@FTLems ?

@FTLems
Copy link
Contributor Author

FTLems commented May 24, 2023

Panel kan brukes ja, men syns det kan være forvirrende om man skal bruke et faktisk panel for warning/error og deretter bruke samme format for gruppering av spørsmål? Jeg er ikke noe UX-designer, men bare en tanke.
Har utviklet flere apper hvor vi da ikke har brukt gruppering av spørsmål i det hele tatt.

Så ja, denne kan vente 👍

@bjosttveit bjosttveit self-assigned this May 25, 2023
@bjosttveit bjosttveit moved this from 📈 Todo to 👷 In Progress in Team Apps May 25, 2023
@bjosttveit bjosttveit moved this from 👷 In Progress to 🔎 Review in Team Apps May 26, 2023
@github-project-automation github-project-automation bot moved this to Ready for dev in Design Altinn 3 May 30, 2023
@bjosttveit bjosttveit moved this from 🔎 Review to 🧪 Test in Team Apps May 30, 2023
@RonnyB71 RonnyB71 moved this from 🧪 Test to ✅ Done in Team Apps Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-complete Features needed for parity with Altinn 2 (target: June 2023) kind/user-story Used for issues that describes functionality for our users. org/krt ux Needs some love from a UX resource
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants