Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Rediger" should be named "Lukk" when open #441

Closed
Magnusrm opened this issue Sep 7, 2022 · 1 comment
Closed

"Rediger" should be named "Lukk" when open #441

Magnusrm opened this issue Sep 7, 2022 · 1 comment
Labels
org/ssb Issues relevant for Statistisk sentralbyrå.

Comments

@Magnusrm
Copy link
Contributor

Magnusrm commented Sep 7, 2022

@chrhaugland commented on Tue Jun 15 2021

Is your feature request related to a problem? Please describe

In a repeating group each row can be edited (Rediger), but the name is still 'Rediger' when the row is open.

Describe the solution you'd like

Im my opinion the label shoud be named 'Rediger' when the row is closed, but be renamed to 'Lukk' when a row is open (for editing)

Describe alternatives you've considered

Since data is saved when you close the row, the label could be called 'Lagre'

Additional context

image


@rvessb commented on Thu Jun 24 2021

Teksten på den blå lagre-knappen bør være den samme som vises oppe ved "blyanten". Ellers vil man tro at man kan lukke uten å lagre.

Helst skulle man selv kunne valg hvilken tekst som skal vises for de forskjellige "tilstandene" raden kan ha. Det gjelder da også teksten på den blå "lagre-knappen".

@bjosttveit
Copy link
Member

Det er nå mulig å overstyre teksten til rediger-knappen ved å sette edit_button_open og edit_button_close i textResourceBindings til gruppen: https://docs.altinn.studio/nb/app/development/ux/fields/grouping/setup/

I #526 ble det endret slik at standard tekst på rediger-knappen er det samme som lagre-knappen når raden er åpen (dvs. "Lagre og lukk").

Repository owner moved this from 📈 Todo to 🧪 Testing in Improvements repeating groups Oct 12, 2022
@bjosttveit bjosttveit moved this to Done in Issues SSB Oct 12, 2022
@bjosttveit bjosttveit moved this to ✅ Done in Team Apps Oct 12, 2022
@bjosttveit bjosttveit moved this from 🧪 Testing to ✅ Done in Improvements repeating groups Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
org/ssb Issues relevant for Statistisk sentralbyrå.
Projects
Archived in project
Archived in project
Status: Done
Development

No branches or pull requests

3 participants