Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker: Clean up and modernize validations #600

Closed
4 tasks done
olemartinorg opened this issue Nov 1, 2022 · 1 comment · Fixed by #636
Closed
4 tasks done

Datepicker: Clean up and modernize validations #600

olemartinorg opened this issue Nov 1, 2022 · 1 comment · Fixed by #636
Assignees

Comments

@olemartinorg
Copy link
Contributor

olemartinorg commented Nov 1, 2022

Description

The Datepicker component suffers from validation duplication, as it keeps validation messages both locally and in Redux. The function validateDatepickerFormData is called both in validation.ts and in DatepickerComponent - but we should aim to keep the validation state in redux only.

Additional Information

Tasks

  • Remove duplicate/local validation in DatepickerComponent.tsx, move missing validation into validation.ts
  • Implement delayed saving with useDelayedSavedState if useful
  • Make sure required field validation does not run immediately if field is empty (should only run when clicking next)
  • Make sure validation works when Datepicker is in a repeating group

Acceptance Criterias

No response

@olemartinorg olemartinorg added status/draft Status: When you create an issue before you have enough info to properly describe the issue. quality/debt labels Nov 1, 2022
@bjosttveit bjosttveit moved this to 📈 Todo in Team Apps Nov 4, 2022
@bjosttveit bjosttveit self-assigned this Nov 4, 2022
@bjosttveit bjosttveit moved this from 📈 Todo to 👷 In Progress in Team Apps Nov 4, 2022
@bjosttveit bjosttveit mentioned this issue Nov 8, 2022
4 tasks
@bjosttveit bjosttveit moved this from 👷 In Progress to 🔎 Review in Team Apps Nov 8, 2022
@bjosttveit bjosttveit removed their assignment Nov 8, 2022
Repository owner moved this from 🔎 Review to ✅ Done in Team Apps Nov 10, 2022
@bjosttveit bjosttveit moved this from ✅ Done to 🧪 Test in Team Apps Nov 10, 2022
@olemartinorg olemartinorg self-assigned this Nov 11, 2022
@olemartinorg
Copy link
Contributor Author

Tested, working wonderfully!

@olemartinorg olemartinorg moved this from 🧪 Test to ✅ Done in Team Apps Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants