chore(graphql): Remove HasOnlyAccessToSubParties from sub-party

[oskogstad]

Description

Related Issue(s)

• #{issue number}

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

• Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

[coderabbitai]

📝 Walkthrough

Walkthrough

This update revises the access control representation in both the GraphQL schema and the corresponding C# classes. In the GraphQL schema, the hasOnlyAccessToSubParties field is now added to the AuthorizedParty type and removed from the AuthorizedSubParty type. Correspondingly, in the C# implementation, the HasOnlyAccessToSubParties property is moved from the AuthorizedPartyBase class to the AuthorizedParty class.

Changes

File	Change Summary
docs/schema/V1/schema.verified.graphql	Added hasOnlyAccessToSubParties: Boolean! to the AuthorizedParty type and removed the same field from the AuthorizedSubParty type.
src/Digdir.Domain.Dialogporten.GraphQL/.../ObjectTypes.cs	Removed the HasOnlyAccessToSubParties property from the AuthorizedPartyBase class and added it to the AuthorizedParty class.

Suggested reviewers

• knuhau

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 69d75a6 and 4ae2063.

📒 Files selected for processing (2)

• docs/schema/V1/schema.verified.graphql (1 hunks)
• src/Digdir.Domain.Dialogporten.GraphQL/EndUser/Parties/ObjectTypes.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Dry run deploy apps / Deploy job sync-resource-policy-information-job to test
• GitHub Check: Dry run deploy apps / Deploy job sync-subject-resource-mappings-job to test
• GitHub Check: build / build-and-test

🔇 Additional comments (2)

src/Digdir.Domain.Dialogporten.GraphQL/EndUser/Parties/ObjectTypes.cs (1)

15-19: Appropriate relocation of HasOnlyAccessToSubParties property

The HasOnlyAccessToSubParties property has been moved from the AuthorizedPartyBase class to the AuthorizedParty class, which is a logical change. This property is conceptually only relevant for the parent party that might have access restrictions to its sub-parties, not for the sub-parties themselves.

This change aligns well with the principle of keeping properties in the most specific class where they're relevant, rather than in a base class where they might not apply to all inheriting classes.

docs/schema/V1/schema.verified.graphql (1)

68-70: Consistent schema update for hasOnlyAccessToSubParties field

The GraphQL schema has been correctly updated to include the hasOnlyAccessToSubParties field in the AuthorizedParty type, which aligns with the corresponding C# code change. This ensures consistency between the backend implementation and the API schema exposed to clients.

The relocation of this field from AuthorizedSubParty to AuthorizedParty makes the API more intuitive, as this property conceptually only applies to a parent party that might have restricted access to its sub-parties.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.