Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we populate data that somehow were not set (performedBy for example) #639

Closed
3 tasks
arealmaas opened this issue Apr 16, 2024 · 1 comment
Closed
3 tasks
Labels
bug Something isn't working

Comments

@arealmaas
Copy link
Collaborator

Introduksjon

Example: If we fail to fetch data from registries when populating performedBy on an activity if not present, we should not fail the request, but we should ensure that we in a near future update this data when the registry is available again.

Beskrivelse

Related issue: #387

Implementasjon

TODO: Spec out an implementation here.

Rough draft:

  • If request fails, add a message on the the service bus
  • In the body of the message, indicate what should be done.

Message:

{
      "orgNumber":"qr23r2",
      "activityId": "qr23r2",
      "event": "PopulateData",
      "type": "PopulatePerformedBy"
 }

Oppgaver

Preview Give feedback

Akseptansekriterier

GITT that we want to store data from third party systems
NÅR the data fetch from these third party systems fail
the system should:

  • Complete the request without the data being set.
  • Log a warning indicating the failure.
  • Ensure we refetch this data asynchronously and store it
@elsand
Copy link
Member

elsand commented Jan 9, 2025

As far as I can tell, the only case where this is relevant is handling actor name lookups in relation to the seen log. For all other cases, including performedBy in activity, failing the lookup should also fail the dialog create/update command, avoiding a state where the name is missing.

Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants