Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling - Ian: log entry (DE) #394

Open
1 task done
m0ezes opened this issue Sep 6, 2024 · 5 comments
Open
1 task done

Spelling - Ian: log entry (DE) #394

m0ezes opened this issue Sep 6, 2024 · 5 comments
Labels
validation: required This issue needs validation from one of the validators.

Comments

@m0ezes
Copy link

m0ezes commented Sep 6, 2024

Please agree to the following

Describe the typo

In the German localization of the game (1.08j CD version) there are several typos in a log entry during the quest "Secretion of the Minecrawlers" in the second chapter. The log entry appears after delivering the gear wheel to Ian, the boss of the Old Mine:

"Ich habe Ian das Zahnrad des verlassenen Erzstampfers gebracht.Ian sagte mir,wenn ich Asgahn die Worte ALLES WIRD GUT sagen, dann wird er das Tor zu den dunklen Schächten öffnen."

  • there are missing several space characters
  • wrong spelling of NPC name "Asghan"
  • wrong use of "sagen" instead of "sage"
  • grammatically, "er" in "[...] dann wird er das Tor [...] öffnen" refers to Ian himself and not to Asghan

Ian-text-bug

Expected spelling

Changed content of "B_LogEntry" (line 336) in "DIA_STT_301_Ian.d" from "Ich habe Ian das Zahnrad des verlassenen Erzstampfers gebracht.Ian sagte mir,wenn ich Asgahn die Worte ALLES WIRD GUT sagen, dann wird er das Tor zu den dunklen Schächten öffnen." to "Ich habe Ian das Zahnrad des verlassenen Erzstampfers gebracht. Ian sagte mir, wenn ich Asghan die Worte ALLES WIRD GUT sage, dann wird dieser das Tor zu den dunklen Schächten öffnen.".

@m0ezes m0ezes added the validation: required This issue needs validation from one of the validators. label Sep 6, 2024
@AmProsius
Copy link
Owner

Thank you for this spelling issue!

While I agree with almost everything, I wouldn't change the last part:

grammatically, "er" in "[...] dann wird er das Tor [...] öffnen" refers to Ian himself and not to Asghan

As this is grammatically ambiguous, it would mean that this change would be more or less opinionated. I agree that "dieser" would be more clear, but we don't aim to make the game better, only less worse.

So my suggestion would be:

Ich habe Ian das Zahnrad des verlassenen Erzstampfers gebracht. Ian sagte mir, wenn ich Asghan die Worte ALLES WIRD GUT sage, dann wird er das Tor zu den dunklen Schächten öffnen.

@AmProsius
Copy link
Owner

AmProsius commented Sep 6, 2024

Every entry in this topic has spelling errors.

Der Guru Cor Kalom hat mich beauftragt, in der Alten Mine nach einer Quelle für Minecrawlersekret zu suchen. Bisher wurden dafür die Zangen dieser Monster benutzt, doch ich soll etwas anderes, besonderes, finden, aus dem man ein besonders starkes Sekret herstellen könnte.
---
Asghan, der Chef der Minengardisten, weigert sich, das Tor zu öffnen. Er will erst die Erlaubnis von Ian haben.
---
Ian der Minenboss will mir nicht helfen, das Nest zu finden. Ich soll ihm erst ein neues Zahnrad für ihren kaputten Erzstampfer besorgen. Er erwähnte einen verlassenen Nebenstollen, in dem sich noch ein alter Stampfer befinden soll.
---
Ich habe Ian das Zahnrad des verlassenen Erzstampfers gebracht. Ian sagte mir, wenn ich Asghan die Worte ALLES WIRD GUT sage, dann wird er das Tor zu den dunklen Schächten öffnen.
---
Trotz Ians Einwilligung will Asghan das Tor erst öffnen, [...]

@szapp
Copy link
Collaborator

szapp commented Sep 6, 2024

Looks also great to me, thanks for reporting! That log entry really needs some fixing.

I suppose grammatical fixes are sometimes quite essential. The case of "er" versus "dieser" is rather minor and does not necessarily fix anything clearly broken. I am mostly in favor for keeping it minimal with the fixes. This also has to do with the process of fixing: The more constraints on what we expect to be broken the narrower the patch can address any issues in potentially half-fixed environments (other mods than the original Gothic). Nevertheless, we usually discuss every suggestion in the issue comments until settling on what to fix each time.

Just a quick note @m0ezes. We tend to continuously edit the title and text of reported issues. If we adjust your text that has nothing to do with the quality of your report. It's rather about formatting and updating the specifics throughout the discussion on the details.


@AmProsius let's use this issue to discuss the extent of the problems in the log topic. Most likely every log entry will later be it's own fix, I think.

@AmProsius
Copy link
Owner

@AmProsius let's use this issue to discuss the extent of the problems in the log topic. Most likely every log entry will later be it's own fix, I think.

Exactly my thoughts. Let's see how soon we will hit the threshold of 999 fixes 😂

@m0ezes
Copy link
Author

m0ezes commented Sep 6, 2024

Thanks for your feedback!

@AmProsius I think you are right about "er" and "dieser". This would be more of an improvement than a fix. So I agree with your change of my text correction.

You should check your corrections for the other entries. You created some new mistakes. ;-)


@szapp Feel free to change title and text of my reported issue as it fits your needs!

General question: as stated above, almost every log entry for this quest line (and for almost all other quest lines in the game) has at least one missing space character or some other typo(s). Should we collect all typos for this quest line here in this thread or only the ones that get triggerd after talking to NPC "Ian" (script "DIA_STT_301_Ian.d")?

Not 100% sure if I triggered all available journal entries for this quest line, but here are two additional screenshots of the other log entries:

Screenshot 2:
Ian-2

Screenshot 3 (only to show the last entry in its entirety):
Ian-3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation: required This issue needs validation from one of the validators.
Projects
None yet
Development

No branches or pull requests

3 participants