Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use atomic_element_unordered_copy_memory_nonoverlapping to read the data #4

Open
htfy96 opened this issue Jun 2, 2019 · 1 comment

Comments

@htfy96
Copy link

htfy96 commented Jun 2, 2019

rust-lang/rust#58599
https://internals.rust-lang.org/t/expose-llvm-atomic-memcpy-in-intrinsics/9466/4

The volatile_read here is an questionable operation which depends on internal implementations to synchronize reads with the previous read-acquire on seqlock.

Ref: #2

@htfy96 htfy96 changed the title Use atomic_element_unordered_copy_memory_nonoverlapping to read the data Use atomic_element_unordered_copy_memory_nonoverlapping to read the data Jun 2, 2019
@htfy96 htfy96 changed the title Use atomic_element_unordered_copy_memory_nonoverlapping to read the data Use atomic_element_unordered_copy_memory_nonoverlapping to read the data Jun 2, 2019
@Amanieu
Copy link
Owner

Amanieu commented Jun 3, 2019

AFAIK these intrinsics don't work correctly at the moment or generate poor code quality. But it's true that eventually we will want to use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants