Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site with port doesn't work 100% #109

Closed
djcaesar9114 opened this issue Apr 4, 2022 · 2 comments
Closed

Site with port doesn't work 100% #109

djcaesar9114 opened this issue Apr 4, 2022 · 2 comments

Comments

@djcaesar9114
Copy link

Hello,
In my dev environment I have my app running on localhost:8080. Matomo seems to work correctly, but although the real time visits counter increments, the actions aren't correct: they show localhost/XXX and not localhost:8080/XXX.
In the websites list it's correctly written localhost:8080.
Am I missing something?
Thanks in advance :)

@AmazingDreams
Copy link
Owner

Hi, this is because the way the page url is determined. The window.location was not updated in the router afterEach hook, so we had to "build" the current page url ourself or the "old" page url would always be passed to matomo (or insert some arbitrary delay or something).

However. I am currently debugging this and I'm noticing that the window.location is updated in the afterEach hook on both vue 2 and vue 3. So maybe we can use window.location again, if this is something that is fixed by Vue.

@AmazingDreams
Copy link
Owner

This has indeed been fixed in vue-router 3.3.0 https://github.com/vuejs/vue-router/blob/dev/CHANGELOG.md#330-2020-05-27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants