New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider ways of fixing issue 6 from g0 group audit #70

Closed

Ivshti opened this issue May 20, 2019 · 0 comments

Member

Ivshti commented May 20, 2019 •

edited

Loading

Anybody can frontrun owner generated call of deployAndFund by either calling deploy or deployAndExecute making the owner's transaction fail. This forces the factory owner to fund the Identity contract in a different way, forcing additional transaction costs.

proposed way to fix this:

ignore errors when deploying
skip deploying if already deployed (seems much better)
two-phase commit system
salt must be related in some way to the caller; this is bad cause the user can't deploy the contract themselves if they have to

For now, option 2 is the frontrunner (lol)

Ivshti mentioned this issue

WIP: IdentityFactory: safer deploy #71

Merged

Ivshti closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment