New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify prices to be per 1 instead of per 1000 (pro mille) #563

Open

8 tasks done

elpiel opened this issue Oct 18, 2022 · 0 comments

Open

8 tasks done

Unify prices to be per 1 instead of per 1000 (pro mille) #563

elpiel opened this issue Oct 18, 2022 · 0 comments

Assignees

Member

elpiel commented Oct 18, 2022 •

edited by simzzz

Loading

We have many places where a UnifedNum price is mentioned and some of them don't mention if they are per 1 or per 1000.

We are looking to unify all prices in the validator to be per 1 and this is a list of most of the places that need unification:

- ValidatorDesc fee (the validator payout should be calculated per 1, right now it's per 1000)
- Targeting - event price
- Campaign - Pricing bounds
- AdView manager - NextAdUnit price
- units-for-slot - UnitsWithPrice
- Config limits - units for slot - global_min_impression_price

Tasks:

Change and document all prices in the systems from the list above to be per 1 event.
Research and change (if any) other places that need changing as well.

elpiel pinned this issue

simzzz self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment