Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP #61 AdEx v5: Unified precision (8) #342

Open
4 tasks
Tracked by #385
elpiel opened this issue Mar 22, 2021 · 0 comments
Open
4 tasks
Tracked by #385

AIP #61 AdEx v5: Unified precision (8) #342

elpiel opened this issue Mar 22, 2021 · 0 comments
Assignees
Milestone

Comments

@elpiel
Copy link
Member

elpiel commented Mar 22, 2021

https://github.com/AdExNetwork/aips/issues/61

Rust reference:

Issue: AmbireTech/adex-validator-stack-rust#384
PRs: AmbireTech/adex-validator-stack-rust#386


Create a Unified Precision number (UnifiedNum) with precision of 8 that will be used for all calculations, except when we are creating the MerkleTree, where we need the actual precision of the token in order of the MerkleTree to be calculated properly.

  • Token configuration of actual precision (in the configuration of the whitelisted token addresses)
  • MerkleTree should use actual precision of the token (e.g. DAI - 18, USDT - 6, etc.)
  • Use Unified Precision - UnifiedNum (including DB) & floor all the calculations
  • Targeting rules DSL - use UnifiedNum instead of BigNum (see: V5 Targeting DSL - UnifiedNumber instead of BigNumber adex-protocol#67)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants