Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for Statement #3

Open
Benjamin-Davies opened this issue Sep 26, 2019 · 0 comments · May be fixed by #4
Open

Add API for Statement #3

Benjamin-Davies opened this issue Sep 26, 2019 · 0 comments · May be fixed by #4

Comments

@Benjamin-Davies
Copy link

Benjamin-Davies commented Sep 26, 2019

This library supplies a promisified of node-sqlite3's Database class. However, it does not do anything about the Statement class.

The Statement class supplies an API that allows the user to supply parameters to their queries. This is better than the API that is supplied by the Database class as it allows the user to avoid SQL injection vulnerabilities (TryGhost/node-sqlite3/issues/57). By not extending this class, your library is discouraging its use and encouraging bad practices.

@Benjamin-Davies Benjamin-Davies linked a pull request Sep 26, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant