Matrix properties incorrectly declared outside cbuffer during batch save

[iris-futur]

We ran into an issue where, for a URP shader with a Matrix4x4 property, the property was not included in the cbuffer as it should be. The issue is easiest to reproduce consistently when using the Batch Save and Pack window.

In trying to recreate a minimal example, I found that the bug depends on the value of internal node IDs. I attach two versions of a trivial shader, one which reproduces the issue and one which does not.

BadCBufferRepro.zip

Running with a debugger attached, in Matrix4X4Node.GenerateShaderForOutput, CurrentParameterType is Global instead of Property. I have not fully investigated the logic, but we have worked around the issue locally by hard-coding ParentGraph.IsSRP to always return true.

[Dawie3565]

@iris-futur
thank you for the report

I see your ASE version you're in is v1.9.6.3 dated around 8/15/2014

Many ASE matrix nodes have since updated
please update to the latest ASE version and try again

Thank you
David

[iris-futur]

Hi David, thanks for pointing that out, I've now updated to the latest 1.9.8.1. Unfortunately the same issue occurs. I have attached an updated version of the shaders saved with 1.9.8.1.

BadCBufferRepro-1.9.8.1.zip