-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor svgFill to pass a custom color #576
Comments
I will pick this up |
Maybe we can also change this in the Paragraph component? It has a similar issue. |
@robinpiets Could you give an example? |
Now Paragraph uses TypographyStyle, and
We can change this to pass a string, so we can use it like this: |
Makes sense, I'd like to see that as well. Although I wonder why this prop exists in the first place since it's just a text element. Should we remove it instead? |
Yeah, it's a strange prop. Shall I make a new PR to change it into this:
|
Sounds good, but let's deprecate the property at the same time. People should just style it in the color they need using |
I will fix the Paragraph color prop in a separate PR |
The
svgFill
method should be refactored to accept a color code only. Also note that the color prop for theIcon
component will have to start using this method.See discussion in #574
The text was updated successfully, but these errors were encountered: