feat: Add date input #1152
Merged
feat: Add date input #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat/DES-666-add-date-input
github-actions
bot
temporarily deployed
to
demo-DES-666-add-date-input
…erdam/design-system into feat/DES-666-add-date-input
github-actions
bot
temporarily deployed
to
demo-DES-666-add-date-input
github-actions
bot
temporarily deployed
to
demo-DES-666-add-date-input
github-actions
bot
temporarily deployed
to
demo-DES-666-add-date-input
github-actions
bot
temporarily deployed
to
demo-DES-666-add-date-input
|
Off the bat, the input appears blank on mobile devices (both android and apple) 
This looks like default behaviour but perhaps we can still show the calendar icon? |
VincentSmedinga
approved these changes
Apr 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native date input looks different on Chromium browsers and Firefox, and even more so on Android and iOS.
The icon currently looks as designed on Chromium. On Firefox the icon is difficult to style. Android and iOS do not have a calender icon, but we could add it of course.