Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIFE v2 models seem to drastically lower visual quality. #38

Open
mlbrnm opened this issue Apr 11, 2023 · 6 comments
Open

RIFE v2 models seem to drastically lower visual quality. #38

mlbrnm opened this issue Apr 11, 2023 · 6 comments

Comments

@mlbrnm
Copy link

mlbrnm commented Apr 11, 2023

Please see the last few posts on this thread:

https://www.svp-team.com/forum/viewtopic.php?id=6281&p=30

This was hypothesized by one person, then confirmed by 2 others on different setups using different media players.

Seems like the V2 models cause major jagged edges in certain situations.

https://i.imgur.com/gqoKFqP.png

https://cdn.discordapp.com/attachments/290709370600423424/1095130933562187847/image.png

But thanks for your great work on this in general. Love it.

@WolframRhodium
Copy link
Contributor

If the issue disappears with `fp16` disabled, it could be a precision problem?

@mlbrnm
Copy link
Author

mlbrnm commented Apr 11, 2023

If the issue disappears with fp16 disabled, it could be a precision problem?

Unfortunately I am not that knowledgeable regarding AI/CUDA/etc and do not know how to test that, but I'd be happy to try if you have instructions/info.

@WolframRhodium
Copy link
Contributor

Find test.py in the svp installation and look into it.

@aloola18
Copy link

Here is my config.
clip = RIFE(clip, multi=2, model=46, _implementation = 2, backend=BackendV2.TRT( device_id=0, fp16 = False, num_streams=2, output_format=1, use_cuda_graph=True, use_cudnn=False, workspace=None, static_shape = 1))

fp16=False + output_format=0 : slower than RIFE v1, but doesn't affect video quality.
fp16=False + output_format=1 : Same as above.
fp16=True + output_format=1: Faster than RIFE v1, but video quality looks really bad, especially on 4k videos.

I use the video to test
https://drive.google.com/file/d/1dfR5TTnsQWX9PVIl-PVujFM_bGfEXUvJ/edit

no rife or RifeV1:
https://cdn.discordapp.com/attachments/290709370600423424/1095138870187798578/LG_4K_HDR_Demo_-_New_York.ts_4_11_2023_7_09_06_AM.png

RIFEv2 + fp16 true
https://cdn.discordapp.com/attachments/290709370600423424/1095138871580315688/LG_4K_HDR_Demo_-_New_York.ts_4_11_2023_7_09_37_AM.png

@hooke007
Copy link
Contributor

hooke007 commented Apr 11, 2023

#22 (comment)
I retested and the confirmed that v2 could not run with fp16. You doesn't use the flag force_fp16, so it might skip many things.

@V85Sf
Copy link

V85Sf commented Jul 15, 2023

I also enabled fp16 in the same way, and when I frame interpolated a 2560x1440 video, a major jagged edge occurred.
However, when I frame interpolate a 1920x1080 video with the same settings, no jaggedness occurs.
Also, if fp16 is disabled, no jaggedness occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants