Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker file for golden generation #382

Open
fredpetersen opened this issue Dec 6, 2022 · 0 comments · May be fixed by #558
Open

Docker file for golden generation #382

fredpetersen opened this issue Dec 6, 2022 · 0 comments · May be fixed by #558
Assignees
@fremartini
Labels
code/dev DX; technical debt; issue concerns code readability or quality research Further research is needed

Comments

@fredpetersen
Copy link
Contributor

Currently goldens only pass flutter test step in pipeline, if generated by a linux machine.

There should be a docker file readily available for generating golden files, so we're not dependant on our linux developers when changing our ui
@marfavi marfavi mentioned this issue Apr 18, 2023
Merged
@marfavi marfavi added research Further research is needed code/dev DX; technical debt; issue concerns code readability or quality and removed good first issue labels Apr 24, 2023
@marfavi marfavi mentioned this issue Apr 25, 2023
Open
@fremartini fremartini assigned fremartini and unassigned duckth Dec 3, 2023
@fremartini fremartini linked a pull request Dec 3, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fremartini fremartini

Labels
code/dev DX; technical debt; issue concerns code readability or quality research Further research is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

run tests in Docker container / generate goldens AnalogIO/coffeecard_app
4 participants
@duckth @marfavi @fremartini @fredpetersen