Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A simplier way to bind in devices #117

Closed
trapexit opened this issue Oct 27, 2020 · 4 comments
Closed

A simplier way to bind in devices #117

trapexit opened this issue Oct 27, 2020 · 4 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@trapexit
Copy link

/dev/sd* are ephemeral names and hard coding them in Docker is not ideal. I've poked around a bit and not seen anything to make this easier but perhaps replacing or augmenting smartctl --scan with something more bespoke. Maybe allow bind mounting the host /dev into the container somewhere and then crawling the path for devices?

@AnalogJ
Copy link
Owner

AnalogJ commented Nov 3, 2020

Hey @trapexit
yeah, I'm not a fan of the /dev/sd* mounting. However, under the hood Scrutiny uses WWN to uniquely identify drives, so it shouldn't matter if the device file assignment changes.

I did use a /dev folder bind mount previously, and it does work (and should continue to work).

@ptr727
Copy link

ptr727 commented Dec 3, 2020

Would also like to see an easier way of device discovery, or why specify them at all vs. just discovering them?
As for sd* notation, I use ZFS and ata* notation, so sd* is not used in any deterministic config.

@AnalogJ
Copy link
Owner

AnalogJ commented Apr 25, 2021

The reason you have to specify them is that the docker --device parameter doesn't natively support wildcards, so you cant do --device /dev/sd* or --device /dev/ata*. Even though Scrutiny doesn't actually use the device by those names, they are still necessary (unless you do a straight -v /dev:/dev bind mount).

@AnalogJ
Copy link
Owner

AnalogJ commented Apr 25, 2021

I'm going to close this for now as a non-issue. But if someone has a better way for passing all hard disk devices into the container (other than -v /dev:/dev, which should already be documented in the README), I'm happy to take another look at this.

@AnalogJ AnalogJ closed this as completed Apr 25, 2021
@AnalogJ AnalogJ added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants