Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Show node id on temperature graph tooltip #216

Closed
FingerlessGlov3s opened this issue Mar 5, 2022 · 3 comments
Closed

[FEAT] Show node id on temperature graph tooltip #216

FingerlessGlov3s opened this issue Mar 5, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested

Comments

@FingerlessGlov3s
Copy link

Is your feature request related to a problem? Please describe.
When looking at the temperature graph at the bottom of the homepage. When you mouse over a data point to view its temperature there's no way to tell which /dev/sda drive it is.

This is only an issue when you multiple nodes all with their own /dev/sda drive.

Describe the solution you'd like
An extra line of text on the tooltip to display node id if available.

Additional context
No way to know which disk this is.
image

@AnalogJ AnalogJ added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested labels Apr 28, 2022
@AnalogJ
Copy link
Owner

AnalogJ commented Apr 28, 2022

This should be partially fixed by #22, since the amount of data visible in the UI will be much more reasonable.
However, as you noticed, this will still be an issue for multi-node deployments.

We could add the node label as a prefix to the drive name. Another alternative would be to use the WWN identifier/UUID instead of disk name. Any preference?

@FingerlessGlov3s
Copy link
Author

WWN is probably preferred, as this should be unique.

@AnalogJ
Copy link
Owner

AnalogJ commented May 25, 2022

fixed in v0.4.7 🎉

@AnalogJ AnalogJ closed this as completed May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants