You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When building the app, a bunch of type related messages come up. It would be good to fix them.
% yarn build
yarn run v1.22.5
$ greenwood build
-------------------------------------------------------
Welcome to Greenwood (v0.22.1) ♻️
-------------------------------------------------------
Running Greenwood with the build command.
Initializing project config
Initializing project workspace contexts
Generating graph of workspace files...
building from local sources...
pages to generate
/Users/owenbuckley/Workspace/analogstudios.net/repo/www.analogstudios.net/src/index.html
success, done generating all pages!
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing './card.model.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '../../services/events/events-service.js' instead.
@rollup/plugin-typescript TS2339: Property 'date' does not exist on type '{ new (type: string, eventInitDict?: EventInit): Event; prototype: Event; readonly AT_TARGET: number; readonly BUBBLING_PHASE: number; readonly CAPTURING_PHASE: number; readonly NONE: number; }'.
@rollup/plugin-typescript TS2339: Property 'date' does not exist on type '{ new (type: string, eventInitDict?: EventInit): Event; prototype: Event; readonly AT_TARGET: number; readonly BUBBLING_PHASE: number; readonly CAPTURING_PHASE: number; readonly NONE: number; }'.
@rollup/plugin-typescript TS2339: Property 'hasEvents' does not exist on type '{ new (type: string, eventInitDict?: EventInit): Event; prototype: Event; readonly AT_TARGET: number; readonly BUBBLING_PHASE: number; readonly CAPTURING_PHASE: number; readonly NONE: number; }'.
@rollup/plugin-typescript TS2339: Property 'date' does not exist on type '{ new (type: string, eventInitDict?: EventInit): Event; prototype: Event; readonly AT_TARGET: number; readonly BUBBLING_PHASE: number; readonly CAPTURING_PHASE: number; readonly NONE: number; }'.
@rollup/plugin-typescript TS2339: Property 'hasEvents' does not exist on type '{ new (type: string, eventInitDict?: EventInit): Event; prototype: Event; readonly AT_TARGET: number; readonly BUBBLING_PHASE: number; readonly CAPTURING_PHASE: number; readonly NONE: number; }'.
@rollup/plugin-typescript TS2339: Property 'events' does not exist on type '{ new (type: string, eventInitDict?: EventInit): Event; prototype: Event; readonly AT_TARGET: number; readonly BUBBLING_PHASE: number; readonly CAPTURING_PHASE: number; readonly NONE: number; }'.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '../../services/posts/posts-service.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing './store.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '/routes/albums/album-details.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '/routes/albums/albums.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '/routes/artists/artist-details.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '/routes/artists/artists.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '/routes/contact/contact.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '/routes/events/event-details.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '/routes/events/events.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '/routes/home/home.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '../../services/albums/albums-service.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '../../components/card/card.model.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '../../services/albums/album.model.js' instead.
@rollup/plugin-typescript TS2304: Cannot find name 'ga'.
@rollup/plugin-typescript TS2304: Cannot find name 'ga'.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '../../services/albums/albums-service.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '../../components/card/card.model.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '../../services/albums/album.model.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '../../store.js' instead.
@rollup/plugin-typescript TS2304: Cannot find name 'ga'.
@rollup/plugin-typescript TS2304: Cannot find name 'ga'.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '../../services/artists/artists-service.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '../../services/albums/albums-service.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '../../components/card/card.model.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '../../services/artists/artist.model.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '../../services/album/album.model.js' instead.
@rollup/plugin-typescript TS2304: Cannot find name 'ga'.
@rollup/plugin-typescript TS2304: Cannot find name 'ga'.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '../../services/artists/artists-service.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '../../components/card/card.model.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '../../services/artists/artist.model.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '../../store.js' instead.
@rollup/plugin-typescript TS2304: Cannot find name 'ga'.
@rollup/plugin-typescript TS2304: Cannot find name 'ga'.
@rollup/plugin-typescript TS2415: Class 'ContactRouteComponent' incorrectly extends base class 'LitElement'.
Property 'connectedCallback' is protected in type 'ContactRouteComponent' but public in type 'LitElement'.
@rollup/plugin-typescript TS2304: Cannot find name 'ga'.
@rollup/plugin-typescript TS2304: Cannot find name 'ga'.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '../../services/events/events-service.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing '../../services/events/event.model.js' instead.
@rollup/plugin-typescript TS2304: Cannot find name 'ga'.
@rollup/plugin-typescript TS2304: Cannot find name 'ga'.
@rollup/plugin-typescript TS2415: Class 'EventsRouteComponent' incorrectly extends base class 'LitElement'.
Property 'connectedCallback' is protected in type 'EventsRouteComponent' but public in type 'LitElement'.
@rollup/plugin-typescript TS2304: Cannot find name 'ga'.
@rollup/plugin-typescript TS2304: Cannot find name 'ga'.
@rollup/plugin-typescript TS2415: Class 'HomeRouteComponent' incorrectly extends base class 'LitElement'.
Property 'connectedCallback' is protected in type 'HomeRouteComponent' but public in type 'LitElement'.
@rollup/plugin-typescript TS2304: Cannot find name 'ga'.
@rollup/plugin-typescript TS2304: Cannot find name 'ga'.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing './album.model.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing './artist.model.js' instead.
@rollup/plugin-typescript TS2691: An import path cannot end with a '.ts' extension. Consider importing './post.model.js' instead.
The 'this' keyword is equivalent to 'undefined' at the top level of an ES module, and has been rewritten
...
Details
So although everything works, I could see a situation where someone would want the build to fail instead. Might be nice to understand if this something that can be controlled from tsconfig.json or would need to handled in the Greenwood TS plugin.
Also, not sure if the Greenwood plugin should be giving more errors during development? Maybe it's due to faulty source map support - ProjectEvergreen/greenwood#661?
The text was updated successfully, but these errors were encountered:
Type of Change
Summary
When building the app, a bunch of type related messages come up. It would be good to fix them.
Details
So although everything works, I could see a situation where someone would want the build to fail instead. Might be nice to understand if this something that can be controlled from tsconfig.json or would need to handled in the Greenwood TS plugin.
Also, not sure if the Greenwood plugin should be giving more errors during development? Maybe it's due to faulty source map support - ProjectEvergreen/greenwood#661?
The text was updated successfully, but these errors were encountered: