Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

refactor double usage of <img> tags for event details component #34

Open
2 tasks
thescientist13 opened this issue Apr 18, 2023 · 6 comments
Open
2 tasks
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@thescientist13
Copy link
Contributor

thescientist13 commented Apr 18, 2023

Summary

Coming out of #32 , two <img> tags where used to enable the feature of having the RI map achieve different outcomes for smaller vs larger breakpoints, with usage of positioning since the dotted arrows will go in two different directions based on breakpoint.
https://github.com/AnalogStudiosRI/www.blissfestri.com/blob/main/src/components/event-details/event-details.js

<!-- sm -->
<img src="/assets/images/ri-map.webp" class="hidden sm:block max-w-sm md:max-w-sm lg:max-w-md xl:max-w-md" style="position:absolute; z-index:-1">

...

<!-- xs -->
<img src="/assets/images/ri-map-mobile.webp" class="block sm:hidden pt-2" style="width: 350px"/>

Details

  1. In theory this could / should be refactored down into one <img> tag, likely using a secret
  2. Ideally all the styling should leverage Tailwind classes (instead of inline style attributes)
@thescientist13 thescientist13 added enhancement New feature or request good first issue Good for newcomers labels Apr 18, 2023
@thescientist13 thescientist13 added this to the Site Launch (v1) milestone Apr 18, 2023
@thescientist13 thescientist13 changed the title refactor double usage of <img> tag for event details refactor double usage of <img> tags for event details component Apr 18, 2023
@thescientist13 thescientist13 moved this to 📋 Backlog in Blissfest Website Launch Apr 18, 2023
@Udassi-Pawan
Copy link

Hey @thescientist13,
I would like to work on this issue, would you assign it to me?

@thescientist13
Copy link
Contributor Author

Thanks @Udassi-Pawan , that would be great! 🙌

@Arindam200
Copy link
Contributor

Arindam200 commented Apr 21, 2023

Is this still open? @thescientist13

Can I work on this?

@thescientist13
Copy link
Contributor Author

Hey @Arindam200 , I think someone may be working on this one already but feel free to check back in a bit if it's still open.

@Arindam200
Copy link
Contributor

OK

@thescientist13 thescientist13 moved this from 📋 Backlog to 🏗 In progress in Blissfest Website Launch Apr 24, 2023
@thescientist13 thescientist13 moved this from 🏗 In progress to 👀 In review in Blissfest Website Launch Apr 24, 2023
@thescientist13
Copy link
Contributor Author

thescientist13 commented Apr 24, 2023

@Arindam200
Appreciate your interest in contributing , I'll have a new round of (good first) issues opened by this weekend to build out the rest of the pages for the site. You can checkout #15 to get an idea of what's coming next and would definitely be happy to have any help you can offer! 🙌

( you too @Udassi-Pawan , always appreciate anyone willing to help out :D )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
No open projects
Status: 👀 In review
Development

Successfully merging a pull request may close this issue.

3 participants