Geometry sandcastle examples #1151
Conversation
|
Thanks @hpinkos. I want to look at this before merging, but it probably won't be until Wednesday. |
|
I like the new Sandcastle label; this will go a long way to separate demos from code snippets. Let's rename
How hard is it to add vertical separators between the labels like our toolbar at the top? |
|
Drop all of these comments: /*~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~*/I get that it separates out the Also, use C++ style comments throughout, not C. |
| var positionOnEllipsoid = ellipsoid.cartographicToCartesian(Cesium.Cartographic.fromDegrees(-105.0, 45.0)); | ||
| var boxModelMatrix = Cesium.Matrix4.multiplyByTranslation( | ||
| Cesium.Transforms.eastNorthUpToFixedFrame(positionOnEllipsoid), | ||
| new Cesium.Cartesian3(0.0, 0.0, dimensions.z/2)); |
There was a problem hiding this comment.
dimensions.z / 2.0. Use .0 throughout for whole numbers if your intention is floating-point.
In this, case * 0.5 is better for performance or at least it was years ago.
|
Drop the "Geometry" suffix from each example, e.g., "Circle Outline Geometry" -> "Circle Outline." These are already in the "Geometries" label. Make people read less. People hate to read. Really. |
|
Why do all the examples use opaque geometry? Most applications will use translucency. We should show some of both and our earliest examples in the tutorial should show whatever is the least amount of code to get started (translucent I believe). |
|
|
||
| var positions = []; | ||
| for (var i = 0; i <= 10; ++i) { | ||
| positions.push(ellipsoid.cartographicToCartesian(Cesium.Cartographic.fromDegrees(-100.0 + i, 30.0 + 3*i/2*(i%2)))); |
|
We might want to put the walls in the Wall Geometry example at a higher latitude so they look better for the default camera view. |
|
This is a nice well organized set of examples. I can see adding a few more as the tutorial covers appearances (e.g., using materials instead of just solid colors), but these are a good to start. |
| function registerScroll(demoContainer){ | ||
| if (typeof document.onmousewheel !== 'undefined') { | ||
| demoContainer.addEventListener('mousewheel', function(e) { | ||
| if (typeof e.wheelDelta !== 'undefined' && e.wheelDelta) { |
There was a problem hiding this comment.
Use defined here and below.
There was a problem hiding this comment.
the defined function isn't part of Sandcastle
There was a problem hiding this comment.
Why can't we require in it? What is different about Sandcastle than our other apps?
|
Let's update CHANGES.md. Then this is ready. |
I looked into trying that with no success. Dojo sub-tabs don't seem to be very flexible. |
Ugh. It's not a problem yet, but it will be as we scale this to more labels for more fine-grained examples. |
|
@pjcozzi Did I get everything? |
Conflicts: Apps/Sandcastle/CesiumSandcastle.js CHANGES.md
|
@pjcozzi sweet, I'm glad it was helpful. I merged in master. |
|
Love it. Add polyline volume examples next time you merge master in for #1125. |
I added a sandcastle example for each geometry type. In order to keep these from cluttering the other demos, I put the existing demos on a 'Showcase' tab, and put the new geometry examples on their own tab. I moved the 'All' tab to the end of the tab list.
I also enabled horizontal scrolling with the mouse wheel to all tabs, previously it only worked on the first tab.
This is to accompany the geometry and appearances tutorial I'm working on.